Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compgen implementation #13

Merged
merged 1 commit into from
May 14, 2024
Merged

More compgen implementation #13

merged 1 commit into from
May 14, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented May 14, 2024

No description provided.

@reubeno reubeno enabled auto-merge (squash) May 14, 2024 05:46
@reubeno reubeno merged commit 42f4e67 into main May 14, 2024
5 checks passed
Copy link

Performance Benchmark Report

Benchmark name Baseline (ns) Test/PR (ns) Delta (ns) Delta %
expand_one_string 3318 ns 3314 ns -4 ns 🟢 -0.12%
instantiate_shell 52208 ns 52608 ns +400 ns 🟠 +0.77%
instantiate_shell_with_init_scripts 47789149 ns 48170205 ns +381056 ns 🟠 +0.80%
parse_bash_completion 6629356 ns 6682163 ns +52807 ns 🟠 +0.80%
parse_sample_script 10870 ns 11081 ns +211 ns 🟠 +1.94%
run_echo_builtin_command 91567 ns 91740 ns +173 ns 🟠 +0.19%
run_one_builtin_command 110728 ns 107878 ns -2850 ns 🟢 -2.57%
run_one_external_command 1797351 ns 1797361 ns +10 ns 🟠 +0.00%
run_one_external_command_directly 1026000 ns 1026758 ns +758 ns 🟠 +0.07%

Code Coverage Report

Package Base Coverage New Coverage Difference
cli.src 🟠 73.95% 🟠 73.95% ⚪ 0%
interactive-shell.src 🟢 75.88% 🟢 75.88% ⚪ 0%
parser.src 🟢 85.86% 🟢 85.86% ⚪ 0%
shell.src 🟢 79.98% 🟢 80.58% 🟢 0.6%
shell.src.builtins 🟠 64.03% 🟠 67.57% 🟢 3.54%
Overall Coverage 🟢 78.02% 🟢 79.09% 🟢 1.07%

Minimum allowed coverage is 0%, this run produced 79.09%

@reubeno reubeno deleted the compgen-more branch May 14, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant