Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add os-targeted integration tests #241

Merged
merged 1 commit into from
Oct 26, 2024
Merged

test: add os-targeted integration tests #241

merged 1 commit into from
Oct 26, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 25, 2024

For increased integration coverage, add new jobs that take the produced Linux/x86_64 release binaries and use them to run our compatibility and completion integration tests on each of Fedora, Debian, and Arch Linux.

In the future, we'll want to enable interactive tests and evaluate which other target platforms are appropriate for additional testing.

Copy link

github-actions bot commented Oct 26, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.41 μs -0.01 μs ⚪ Unchanged
instantiate_shell 60.41 μs 59.90 μs -0.51 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 30295.87 μs 30388.89 μs 93.02 μs ⚪ Unchanged
parse_bash_completion 2792.35 μs 2774.44 μs -17.91 μs 🟢 -0.64%
parse_sample_script 4.30 μs 4.17 μs -0.13 μs ⚪ Unchanged
run_echo_builtin_command 90.62 μs 89.82 μs -0.80 μs ⚪ Unchanged
run_one_builtin_command 109.56 μs 109.58 μs 0.02 μs ⚪ Unchanged
run_one_external_command 1908.61 μs 1918.05 μs 9.44 μs ⚪ Unchanged
run_one_external_command_directly 1003.28 μs 1004.95 μs 1.67 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/command.rs 🟢 91.86% 🟢 90.7% 🔴 -1.16%
brush-core/src/jobs.rs 🔴 42.42% 🔴 37.23% 🔴 -5.19%
brush-core/src/shell.rs 🟢 83.52% 🟢 82.77% 🔴 -0.75%
brush-shell/src/args.rs 🟠 63.64% 🟠 62.22% 🔴 -1.42%
brush-shell/src/main.rs 🟢 90.85% 🟢 90.91% 🟢 0.06%
Overall Coverage 🟢 77.1% 🟢 76.96% 🔴 -0.14%

Minimum allowed coverage is 70%, this run produced 76.96%ced_ 73.44%

Copy link

github-actions bot commented Oct 26, 2024

Test Results

  2 files    9 suites   1m 8s ⏱️
499 tests 499 ✅ 0 💤 0 ❌
986 runs  986 ✅ 0 💤 0 ❌

Results for commit caad197.

♻️ This comment has been updated with latest results.

@reubeno reubeno force-pushed the os-tests branch 12 times, most recently from da62a84 to 161e146 Compare October 26, 2024 07:45
@reubeno reubeno changed the title feat: start adding os-specific integration tests test: add os-targeted integration tests Oct 26, 2024
@reubeno reubeno marked this pull request as ready for review October 26, 2024 07:57
@reubeno reubeno merged commit 11b032e into main Oct 26, 2024
14 checks passed
@reubeno reubeno deleted the os-tests branch October 26, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant