Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(set): implement nocaseglob + nocasematch options #282

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Nov 30, 2024

Resolves #228

@reubeno reubeno changed the title feat(set): implement nocaseglob + nocasematch feat(set): implement nocaseglob + nocasematch options Nov 30, 2024
Copy link

Test Results

    2 files      9 suites   1m 11s ⏱️
  532 tests   532 ✅ 0 💤 0 ❌
1 051 runs  1 051 ✅ 0 💤 0 ❌

Results for commit aba4da5.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.43 μs 3.43 μs 0.00 μs ⚪ Unchanged
instantiate_shell 60.55 μs 61.23 μs 0.68 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 31967.97 μs 31486.88 μs -481.09 μs ⚪ Unchanged
parse_bash_completion 2887.82 μs 2892.73 μs 4.91 μs ⚪ Unchanged
parse_sample_script 4.34 μs 4.43 μs 0.09 μs 🟠 +1.98%
run_echo_builtin_command 94.39 μs 91.60 μs -2.79 μs 🟢 -2.95%
run_one_builtin_command 108.47 μs 111.46 μs 2.99 μs 🟠 +2.76%
run_one_external_command 2029.35 μs 1934.00 μs -95.34 μs 🟢 -4.70%
run_one_external_command_directly 1023.31 μs 1024.08 μs 0.77 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/help.rs 🟢 89.41% 🟢 89.66% 🟢 0.25%
brush-core/src/completion.rs 🔴 20.29% 🔴 20.4% 🟢 0.11%
brush-core/src/extendedtests.rs 🟠 69.15% 🟠 69.51% 🟢 0.36%
brush-core/src/interp.rs 🟢 91.16% 🟢 91.2% 🟢 0.04%
brush-core/src/namedoptions.rs 🟠 52.88% 🟠 53.85% 🟢 0.97%
brush-core/src/patterns.rs 🟢 97.92% 🟢 97.95% 🟢 0.03%
brush-core/src/shell.rs 🟢 78.9% 🟢 78.79% 🔴 -0.11%
brush-parser/src/tokenizer.rs 🟢 95.91% 🟢 96% 🟢 0.09%
Overall Coverage 🟢 74.58% 🟢 74.64% 🟢 0.06%

Minimum allowed coverage is 70%, this run produced 74.64%

@reubeno reubeno merged commit 2e9447d into main Nov 30, 2024
17 checks passed
@reubeno reubeno deleted the nocase branch November 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor nocasematch option for case-insensitive matches
1 participant