Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(perf): update tokenizer/parser benchmarks #321

Merged
merged 1 commit into from
Jan 13, 2025
Merged

test(perf): update tokenizer/parser benchmarks #321

merged 1 commit into from
Jan 13, 2025

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 13, 2025

No description provided.

Copy link

github-actions bot commented Jan 13, 2025

Test Results

    2 files      9 suites   1m 21s ⏱️
  585 tests   585 ✅ 0 💤 0 ❌
1 156 runs  1 156 ✅ 0 💤 0 ❌

Results for commit 2b43823.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 13, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 16.58 μs 16.47 μs -0.12 μs 🟢 -0.70%
eval_arithmetic 0.19 μs 0.18 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.57 μs 1.56 μs -0.01 μs ⚪ Unchanged
for_loop 33.14 μs 32.58 μs -0.56 μs ⚪ Unchanged
function_call 3.24 μs 3.33 μs 0.09 μs ⚪ Unchanged
instantiate_shell 47.91 μs 47.50 μs -0.41 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 22146.10 μs 22140.85 μs -5.25 μs ⚪ Unchanged
parse_bash_completion 1662.64 μs 1662.79 μs 0.15 μs ⚪ Unchanged
parse_sample_script 2.16 μs 1.75 μs -0.41 μs 🟢 -19.16%
run_echo_builtin_command 16.23 μs 16.39 μs 0.16 μs ⚪ Unchanged
run_one_external_command 1729.42 μs 2380.86 μs 651.44 μs 🟠 +37.67%

Benchmarks added:

  • tokenize_sample_script

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/set.rs 🟠 60.69% 🟠 59.66% 🔴 -1.03%
brush-core/src/jobs.rs 🔴 37.07% 🔴 43.1% 🟢 6.03%
brush-core/src/shell.rs 🟢 82.27% 🟢 82.4% 🟢 0.13%
brush-parser/src/tokenizer.rs 🟢 96.12% 🟢 96.13% 🟢 0.01%
Overall Coverage 🟢 76.96% 🟢 77.04% 🟢 0.08%

Minimum allowed coverage is 70%, this run produced 77.04%

@reubeno reubeno force-pushed the bench branch 3 times, most recently from a7cd4d8 to bddb219 Compare January 13, 2025 08:20
@reubeno reubeno merged commit 780d42d into main Jan 13, 2025
17 checks passed
@reubeno reubeno deleted the bench branch January 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant