Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from log -> tracing; enable dynamic selection #7

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented May 13, 2024

No description provided.

Copy link

Test Results

344 tests   329 ✅  2m 14s ⏱️
 56 suites   15 💤
  8 files      0 ❌

Results for commit bba35d3.

Copy link

Performance Benchmark Report

Benchmark name Baseline (ns) Test/PR (ns) Delta (ns) Delta %
expand_one_string 3312 ns 3319 ns +7 ns 🟠 +0.21%
instantiate_shell 52167 ns 51763 ns -404 ns 🟢 -0.77%
instantiate_shell_with_init_scripts 27536572 ns 26924012 ns -612560 ns 🟢 -2.22%
parse_bash_completion 6620050 ns 6710867 ns +90817 ns 🟠 +1.37%
parse_sample_script 10899 ns 11066 ns +167 ns 🟠 +1.53%
run_echo_builtin_command 89941 ns 92310 ns +2369 ns 🟠 +2.63%
run_one_builtin_command 107221 ns 110839 ns +3618 ns 🟠 +3.37%
run_one_external_command 1791041 ns 1775159 ns -15882 ns 🟢 -0.89%
run_one_external_command_directly 1032801 ns 1027859 ns -4942 ns 🟢 -0.48%

Code Coverage Report

Package Base Coverage New Coverage Difference
cli.src 🟢 78.82% 🟠 74.58% 🔴 -4.24%
interactive-shell.src 🟢 75.88% 🟢 75.88% ⚪ 0%
parser.src 🟢 85.84% 🟢 85.86% 🟢 0.02%
shell.src 🟢 80.06% 🟢 80.06% ⚪ 0%
shell.src.builtins 🟠 63.98% 🟠 63.98% ⚪ 0%
Overall Coverage 🟢 78.09% 🟢 78.05% 🔴 -0.04%

Minimum allowed coverage is 0%, this run produced 78.05%

@reubeno reubeno merged commit cf53bf2 into main May 13, 2024
5 checks passed
@reubeno reubeno deleted the tracing branch May 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant