Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flexible and convenient new line classes #10

Closed
wants to merge 13 commits into from
Closed

Implement flexible and convenient new line classes #10

wants to merge 13 commits into from

Conversation

ejnnr
Copy link
Contributor

@ejnnr ejnnr commented Jul 5, 2023 •
edited
Loading

Potential todos before merging:

  • Refactor so that less code is duplicated (both within MultiLine and between MultiLine and Arrow
  • Extract most of the logic out of AutoLine so users can easily use the "uldr" syntax for only part of a line
  • Maybe rename AutoLine and MultiLine to something better
  • Actually implement filled arrow heads
  • Make the flow chart example look more sensible
  • Add flow chart example as a test
  • Better documentation of how these new classes can be used

revalo
revalo reviewed Jul 5, 2023
View reviewed changes
iceberg/primitives/multilines.py Outdated

key_points.extend(np.linspace(current, target, len(group) + 1)[1:])

# Now we need to take the zeros into account
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with period.

@ejnnr ejnnr mentioned this pull request Jan 25, 2024
Open
@ejnnr
Copy link
Contributor Author

ejnnr commented Jan 25, 2024

Closing in favor of #17

@ejnnr ejnnr closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revalo revalo revalo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejnnr @revalo