[WIP] Add Patch-Package, Patch nested library, update index #5
Conversation
| @@ -377,9 +377,6 @@ export default class LiveChat extends Component { | |||
| } | |||
|
|
|||
| shouldDisableComposer = () => { | |||
| if (!this.state.onlineStatus && !this.state.chatActive) { | |||
| return true | |||
| } | |||
| if (this.state.queued) { | |||
There was a problem hiding this comment.
@grossvogel @ryanalexanderbrashear What do you all think about instead of removing this completely, we create a new prop that would allow for this to be turned off and on?
Something like
if (!this.state.onlineStatus && !this.state.chatActive && !this.state.allowOfflineMessages) {
return true
}
There was a problem hiding this comment.
Yeah that'd be a bit more friendly, like what you have except I think it'd be !this.props.allowOfflineMessages (instead of ...state...)
|
@ryanalexanderbrashear @grossvogel If I were tests, where would I live in this package? Also is it worth spending the time to write tests for this? I'mma say yes, because it doesn't have any and we're having to do all this to get it to work properly but also 🤷🏻♀️ If I do write some, it will be in a different PR so we don't hold up getting these changes in |
|
@CrystalJewell Test framework setup for react native isn't super straight-forward (and/or I'm just not good at it), and I'm not really sunny on the value of this package as a long-term investment... so I personally wouldn't spend too much time on that but tests are always good |
Patch-Packagehas been added.@liveview/customer-sdkpackage has been patch to fix an auth bug it has.index.jshas been updated to