Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix // Prevents error when nonsense is provided to the /poker start command #439

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

stuartjohnpage
Copy link
Contributor

Overview

  • Previously, hitting slax with something like /poker start asdfasdfasdf would result in a dispatch error
  • This is actually a function clause match error
  • This PR replaces the {_, _} function match with one that will actually match (as Poker.start/1) is only ever called with one argument

@stuartjohnpage stuartjohnpage self-assigned this Jul 17, 2024
@stuartjohnpage stuartjohnpage changed the title Chore // Prevents error when nonsense is provided to the /poker start command Bugfix // Prevents error when nonsense is provided to the /poker start command Jul 17, 2024
Copy link
Contributor

@rgarfield11 rgarfield11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@stuartjohnpage stuartjohnpage merged commit 57fdfd9 into master Jul 17, 2024
1 check passed
@stuartjohnpage stuartjohnpage deleted the fix-blank-start-error branch July 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants