This repository has been archived by the owner on Jun 6, 2020. It is now read-only.
Initial support for CanvasKit / JavaScript version #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
commented
May 19, 2019
| @@ -9,35 +9,35 @@ let imageInfo = Sk.ImageInfo.make(800, 600, N32, Premul, None); | |||
| let surface = Sk.Surface.makeRaster(imageInfo, None); | |||
| let canvas = Sk.Surface.getCanvas(surface); | |||
|
|
|||
| let bgColor = Sk.Color.make(255, 100, 0, 200); | |||
| let bgColor = Sk.Color.makeARGB(255, 100, 0, 200); | |||
There was a problem hiding this comment.
@manuhornung Changed this naming to make more clear which param is what (as CanvasKit has different ordering, I was going crazy 😄 )
| "devDependencies": { "ocaml": "~4.7.0" } |
There was a problem hiding this comment.
Using a more recent version of OCaml (same as Revery).
src/skia.cpp
Outdated
| CAMLprim value | ||
| caml_SkPath_create() | ||
| { | ||
| throw "caml_SkPath_create not implemented yet"; |
There was a problem hiding this comment.
@manuhornung Left these functions as todos. I couldn't compile without at least defining them in cpp too.
| @@ -289,7 +301,10 @@ module Sk = { | |||
|
|
|||
| external getCanvas: t => Canvas.t = "caml_SkSurface_getCanvas"; | |||
|
|
|||
| external makeCanvasSurface: string => t = | |||
| "caml_CanvasKit_MakeCanvasSurface"; | |||
There was a problem hiding this comment.
Not sure if this should belong to CanvasKit or Surface 🤔
| CAMLprim value | ||
| caml_CanvasKit_currentContext(value vCanvasId) | ||
| { | ||
| throw "caml_CanvasKit_MakeCanvasSurface is only available in CanvasKit / JavaScript bindings"; |
There was a problem hiding this comment.
@manuhornung Is there a better way to solve this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some support for the JavaScript / CanvasKit version of SKIA.
Some notes / discoveries:
CanvasKitInitfunction, exposed in the JS filebin/canvaskit.js, and then passing the path to the wasm file as the params to this function, which returns a promise. This means that any code relying on CanvasKit needs to wait until these two files are loaded.The way the jsoo bindings are being designed right now is assuming that
CanvasKitexists already in the global namespace (i.e. bothbin/canvaskit.jsandbin/canvaskit.wasmhave loaded). This makes the code in this repo much simpler but forces the consumers to load these two files manually on their own.To test it:
Screenshot from the example 😄