ARTEMIS-1776] - Implement asynchronous flow control on bridge and clustered bridge #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n bridges The cluster connection bridge hard codes its producerWindowSize to -1 (meaning no producer flow control) even if you configure it otherwise. Cherry-picked from 1e6e1f7
Cherry-picked from 2c73bd0
This is still part of ARTEMIS-1776 fix, which still part of the same release as we are on now. Hence I'm not opening a new JIRA for this one. Cherry-picked from 3c54609
|
Can one of the admins verify this patch? |
spyrkob
pushed a commit
to spyrkob/jboss-activemq-artemis
that referenced
this pull request
Apr 9, 2020
…rectly displayed on console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.apache.org/jira/browse/ARTEMIS-1776
Currently the flow control on the Bridge is based on back pressure only, through Netty writeable interfaces.
If the user selected a positive producerWindowSize the Queue may block while the Processing is happening. What could lead to distributed deadlocks on the Bridge.
These changes avoids that possibility.