Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rustler update to v0.35.0 #221

Merged
merged 5 commits into from
Oct 20, 2024
Merged

fix: rustler update to v0.35.0 #221

merged 5 commits into from
Oct 20, 2024

Conversation

fabriziosestito
Copy link
Collaborator

changes needed to compile against rustler v0.35.0

Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito self-assigned this Oct 19, 2024
@fabriziosestito fabriziosestito added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code chore labels Oct 19, 2024
Copy link
Collaborator

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mind that Clippy is yelling at you because I think you have to either let _ = the resource expressions in lib.rs or explicitly match them if you wanna implement a different logic.

Signed-off-by: Fabrizio Sestito <[email protected]>
@dottorblaster
Copy link
Collaborator

@fabriziosestito one tiny recap before I go to sleep.

I tried to drop _build before running the tests and it works. My theory is that restoring the prebuilt dependencies and compiled code prevents the actual Rust code to be built, especially the dylib .so library that is needed by some of the tests. Dropping _build is a caveman way of triggering the rebuild of just everything.

This is a very naive approach and I absolutely don't like it. 😄

@fabriziosestito
Copy link
Collaborator Author

@dottorblaster I removed the commit you added and now somehow the tests are passing. There was something wrong with the GH cache.

@fabriziosestito fabriziosestito merged commit 7f94aa1 into main Oct 20, 2024
3 checks passed
@fabriziosestito fabriziosestito deleted the fix/rustler-update branch October 20, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants