-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rustler update to v0.35.0 #221
Conversation
Signed-off-by: Fabrizio Sestito <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mind that Clippy is yelling at you because I think you have to either let _ =
the resource expressions in lib.rs
or explicitly match them if you wanna implement a different logic.
Signed-off-by: Fabrizio Sestito <[email protected]>
d593859
to
b00995a
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
20a2e49
to
0d8a159
Compare
@fabriziosestito one tiny recap before I go to sleep. I tried to drop This is a very naive approach and I absolutely don't like it. 😄 |
Signed-off-by: Fabrizio Sestito <[email protected]>
0d8a159
to
53f5b0e
Compare
@dottorblaster I removed the commit you added and now somehow the tests are passing. There was something wrong with the GH cache. |
changes needed to compile against rustler
v0.35.0