Rename Angle::as_* into Angle::from_*
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial names `as_radians`, `as_degrees` and `as_hours` were misleading since we made `Angle` a single class for handling all units of angles, always stored in radians. It use to make sense when we had classes like `Radian`, `Degree` and `Hour`, but now that an angle is always stored in radians, `as_*` could let the reader think that the angle is going to be initialized in the specified unit. These methods have been renamed into the following: * `::from_radians` * `::from_degrees` * `::from_hours` * `::from_dms` * `::from_hms`
rhannequin
added a commit
that referenced
this pull request
Mar 29, 2024
## 0.3.0 - 2024-03-29 _If you are upgrading: please see [`UPGRADING.md`]._ ### Improvements * Drop `Angle#==` ([#42]) * Improved accuracy with Sun's location predictions ([#41]) ### Breaking changes * **breaking:** Difference between true and apparent ecliptic and equatorial coordinates ([#41]) * **breaking:** Rename `Angle::as_*` into `Angle::from_*` ([#43]) [#41]: #41 [#42]: #42 [#43]: #43
rhannequin
added a commit
that referenced
this pull request
Mar 29, 2024
## 0.3.0 - 2024-03-29 _If you are upgrading: please see [`UPGRADING.md`]._ ### Improvements * Drop `Angle#==` ([#42]) * Improved accuracy with Sun's location predictions ([#41]) ### Breaking changes * **breaking:** Difference between true and apparent ecliptic and equatorial coordinates ([#41]) * **breaking:** Rename `Angle::as_*` into `Angle::from_*` ([#43]) [#41]: #41 [#42]: #42 [#43]: #43
rhannequin
added a commit
that referenced
this pull request
Mar 29, 2024
## 0.3.0 - 2024-03-29 _If you are upgrading: please see [`UPGRADING.md`]._ ### Improvements * Drop `Angle#==` ([#42]) * Improved accuracy with Sun's location predictions ([#41]) ### Breaking changes * **breaking:** Difference between true and apparent ecliptic and equatorial coordinates ([#41]) * **breaking:** Rename `Angle::as_*` into `Angle::from_*` ([#43]) [#41]: #41 [#42]: #42 [#43]: #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial names
as_radians,as_degreesandas_hourswere misleading since we madeAnglea single class for handling all units of angles, always stored in radians.It use to make sense when we had classes like
Radian,DegreeandHour, but now that an angle is always stored in radians,as_*could let the reader think that the angle is going to be initialized in the specified unit.These methods have been renamed into the following:
::from_radians::from_degrees::from_hours::from_dms::from_hms