Bump to OSL 1.35 #512
Draft
Bump to OSL 1.35 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-farache
force-pushed
the
osl-1.35
branch
2 times, most recently
from
f17cb0b to
1130853
Compare
gabriel-farache
force-pushed
the
osl-1.35
branch
from
1130853 to
ab7215e
Compare
gabriel-farache
force-pushed
the
osl-1.35
branch
2 times, most recently
from
9172c63 to
935528b
Compare
masayag
approved these changes
Dec 15, 2024
gabriel-farache
force-pushed
the
osl-1.35
branch
from
935528b to
aebc326
Compare
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
osl-1.35
branch
from
aebc326 to
67a3e2a
Compare
masayag
reviewed
Jan 21, 2025
| @@ -13,7 +13,7 @@ FROM ${BUILDER_IMAGE:-registry.redhat.io/openshift-serverless-1/logic-swf-builde | |||
| # When using nightly: | |||
| # ARG QUARKUS_EXTENSIONS=org.kie:kogito-addons-quarkus-jobs-knative-eventing:999-SNAPSHOT,org.kie:kie-addons-quarkus-persistence-jdbc:999-SNAPSHOT,io.quarkus:quarkus-jdbc-postgresql:3.8.4,io.quarkus:quarkus-agroal:3.8.4,org.kie:kie-addons-quarkus-monitoring-prometheus:999-SNAPSHOT,org.kie:kie-addons-quarkus-monitoring-sonataflow:999-SNAPSHOT | |||
| # When using prod: | |||
| ARG QUARKUS_EXTENSIONS=org.kie:kogito-addons-quarkus-jobs-knative-eventing:9.101.0.redhat-00007,org.kie:kie-addons-quarkus-persistence-jdbc:9.101.0.redhat-00007,io.quarkus:quarkus-jdbc-postgresql:3.8.4.redhat-00002,io.quarkus:quarkus-agroal:3.8.4.redhat-00002 | |||
| ARG QUARKUS_EXTENSIONS=org.kie:kogito-addons-quarkus-jobs-knative-eventing:9.102.0.redhat-00004,org.kie:kie-addons-quarkus-persistence-jdbc:9.102.0.redhat-00004,io.quarkus:quarkus-jdbc-postgresql:3.8.6.redhat-00004,io.quarkus:quarkus-agroal:3.8.6.redhat-00004 | |||
There was a problem hiding this comment.
will the monitoring jars be added later?
There was a problem hiding this comment.
They are included by default, otherwise we would not had to removed them manually in the dockerfile: https://github.com/rhdhorchestrator/serverless-workflows/pull/512/files#diff-0c21847f7c6713cdbf85fdc53c9414ccbd57cd13fa7b2370ecc8001055b9ec95L37-L39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to OSL 1.35