tests: apply updates.img with mkksiso script instead of inst.updates #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
mkksiso-updates
branch
2 times, most recently
from
915c27e
to
cfba4e8
Compare
KKoukiou
added a commit
to cockpit-project/cockpituous
that referenced
this pull request
Oct 4, 2024
This is required by anaconda tests as they are using `mkksiso` to adjust the test ISO file. [1] [1]: rhinstaller/anaconda-webui#462
KKoukiou
force-pushed
the
mkksiso-updates
branch
from
cfba4e8
to
6b49de1
Compare
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpituous
that referenced
this pull request
Oct 7, 2024
This is required by anaconda tests as they are using `mkksiso` to adjust the test ISO file. [1] [1]: rhinstaller/anaconda-webui#462
KKoukiou
force-pushed
the
mkksiso-updates
branch
2 times, most recently
from
7b4669b
to
6a7ef2c
Compare
In the meantime remove conditions for ELN to simplify the change, as we don't run test there anymore and the condition is anyhow obsolete. Also bump the container so that it contains mkksiso package provided by lorax.
KKoukiou
force-pushed
the
mkksiso-updates
branch
from
6a7ef2c
to
22b37d2
Compare
|
Maybe I'm wrong but I think you will face an issue that running mkksiso in the container requires loop device available. So you need to have it created somewhere manually because of the issue with losetup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: