Do not permit clicking 'Modify storage' button when installation has been started #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
storage-disabled-when-installing
branch
3 times, most recently
from
e158f37
to
e2dde09
Compare
rvykydal
reviewed
Nov 8, 2024
|
|
||
| useEffect(() => { | ||
| if (path.length === 0 || path[0] !== currentStepId) { | ||
| setCurrentStepId(path[0]); |
There was a problem hiding this comment.
It is expected that in case of empty path currentStepId is set to undefined I think.
There was a problem hiding this comment.
It works yes, but I realize,maybe it would be cleaner to just omit it though. In that case path[0] !== currentStepId would also work, if path[0] is undefined.
KKoukiou
force-pushed
the
storage-disabled-when-installing
branch
from
e2dde09
to
9a6a09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.