Skip to content

Commit

Permalink
Fully deprecate squeeze kwarg to groupby (pydata#9280)
Browse files Browse the repository at this point in the history
* Fully deprecate squeeze kwarg to groupby

Closes pydata#9279
Closes pydata#1460
Closes pydata#2157

* Fix doctests

* Update xarray/core/groupby.py

Co-authored-by: Maximilian Roos <[email protected]>

* Fix whats-new

* Update doc/whats-new.rst

---------

Co-authored-by: Maximilian Roos <[email protected]>
  • Loading branch information
dcherian and max-sixty authored Jul 26, 2024
1 parent 0023e5d commit 53c5634
Show file tree
Hide file tree
Showing 10 changed files with 146 additions and 591 deletions.
8 changes: 4 additions & 4 deletions doc/whats-new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ Breaking changes
``origin`` or ``offset`` parameters is recommended as a replacement for using
the ``base`` parameter and using time offset arithmetic is recommended as a
replacement for using the ``loffset`` parameter.


Deprecations
~~~~~~~~~~~~
- The ``squeeze`` kwarg to ``groupby`` is completely deprecated. This has been the source of some quite confusing
behaviour and has been deprecated since v2024.01.0. `groupby`` behavior is now always consistent
with the existing ``.groupby(..., squeeze=False)`` behavior.
By `Deepak Cherian <https://github.com/dcherian>`_. (:pull:`9280`)


Bug fixes
Expand Down
Loading

0 comments on commit 53c5634

Please sign in to comment.