-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using deprecated Manifest.writeTo(Writer) and use Manifest.writeTo(Object) instead #32
base: master
Are you sure you want to change the base?
Conversation
…teTo(Object) instead In Gradle 4.0 Manifest.writeTo(Writer) will be removed, to make it compatible, Manifest.writeTo(Object) needs to be used
Please merge this we are blocked with version 4 |
Looks like the plugin owner doesn't maintain the project any longer :( |
@alisiikh I contacted him on twitter if we don't get any response should we do a fork of it and maintain it ? |
+1 |
I wrote him on twitter no reaction. Maybe he is on holidays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Please release it. Thanks! |
We have a fork here for those interested. |
Forking is a good first step, but are you publishing it as a plugin in the gradle plugin repository? A link to that would be more helpful (I didn't find it with their search). |
Yes I will publish. Need a couple of days though. |
nice that you published it, but I see you aren't enabling issue reporting on your github repo :( I suppose that's you being upfront about not wanting to maintain it, but the floundering continues the next time something breaks... sigh |
Well ... why not. Issue reporting has been enabled. |
Cool, that's encouraging :) thanks |
fixes issue #34, too |
In Gradle 4.0 Manifest.writeTo(Writer) will be removed, to make it compatible, Manifest.writeTo(Object) needs to be used