Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear data when the close button is clicked #868

Closed
wants to merge 4 commits into from
Closed

Clear data when the close button is clicked #868

wants to merge 4 commits into from

Conversation

CherifAmine
Copy link
Contributor

Description

Changes Made

Closes Issue(s)

Related Issue(s)

#860

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@CherifAmine CherifAmine added component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: rooms Changes related to virtual meeting rooms or spaces. labels Aug 7, 2023
@marwa-benhassine marwa-benhassine added the quality control: changes requested Approved (for when the QA testing team approves the changes) label Aug 7, 2023
@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Aug 7, 2023 •
edited
Loading

When you click the close icon button on the new label, the color is not cleared
the color should return to the default value

color

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
15.0% 15.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@marwa-benhassine
Copy link
Contributor

the shortlink should return to the default value
shortlink

@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Aug 8, 2023 •
edited
Loading

the edit box in a short link stays open when the close button is clicked

@CherifAmine
Copy link
Contributor Author

Replaced by PR : #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhaziTriki GhaziTriki Awaiting requested review from GhaziTriki

@hanazarraa hanazarraa Awaiting requested review from hanazarraa

Assignees

@marwa-benhassine marwa-benhassine

Labels
component: labels Changes related to labeling or categorization of issues or pull requests. component: presets Changes related to predefined settings or configurations. component: rooms Changes related to virtual meeting rooms or spaces. quality control: changes requested Approved (for when the QA testing team approves the changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CherifAmine @marwa-benhassine