-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tcp starttls test for smtp #167
Conversation
@ribbybibby as I understand your code support regex there and should work like a charm, right? |
@dragoangel Thanks for the PR! Could you please update the tests to check this works? |
Will check ✅🙂 |
@ribbybibby can you please check? Hope it okay :D |
Co-authored-by: Rob Best <[email protected]>
@ribbybibby can you please issue a release? :) Would like to pull image with this changes 🙏 |
@ribbybibby sorry for pinging, but can you please create release with this changes? |
@dragoangel v2.4.3 has been released |
Thank you |
When SMTP capability listed as last option it described by " " (space), in nginx smtp proxy with starttls offloading it's common that starttls placed in last sequence, resulting in faled tests from ssl_exporter aka:
This PR should fix such cases