Fix tcp starttls test for smtp #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ribbybibby as I understand your code support regex there and should work like a charm, right? |
|
@dragoangel Thanks for the PR! Could you please update the tests to check this works? |
Will check ✅🙂 |
|
@ribbybibby can you please check? Hope it okay :D |
ribbybibby
reviewed
Mar 21, 2024
ribbybibby
reviewed
Mar 21, 2024
Co-authored-by: Rob Best <[email protected]>
ribbybibby
approved these changes
Mar 22, 2024
|
@ribbybibby can you please issue a release? :) Would like to pull image with this changes 🙏 |
@ribbybibby sorry for pinging, but can you please create release with this changes? |
|
@dragoangel v2.4.3 has been released |
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SMTP capability listed as last option it described by " " (space), in nginx smtp proxy with starttls offloading it's common that starttls placed in last sequence, resulting in faled tests from ssl_exporter aka:
This PR should fix such cases