Use wasm-compatible conditional import in timeline.dart, avoid emitti…

…ng timeline events in SchedulerBinding (flutter#144682)
ricardoamador · Mar 6, 2024 · aba7bc3 · aba7bc3
1 parent 7a88767
commit aba7bc3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/flutter/lib/src/foundation/timeline.dart b/packages/flutter/lib/src/foundation/timeline.dart
@@ -8,7 +8,7 @@ import 'dart:typed_data';
 import 'package:meta/meta.dart';
 
 import '_timeline_io.dart'
-  if (dart.library.js_util) '_timeline_web.dart' as impl;
+  if (dart.library.js_interop) '_timeline_web.dart' as impl;
 import 'constants.dart';
 
 /// Measures how long blocks of code take to run.

diff --git a/packages/flutter/lib/src/scheduler/binding.dart b/packages/flutter/lib/src/scheduler/binding.dart
@@ -1318,13 +1318,17 @@ mixin SchedulerBinding on BindingBase {
       final List<FrameCallback> localPostFrameCallbacks =
           List<FrameCallback>.of(_postFrameCallbacks);
       _postFrameCallbacks.clear();
-      Timeline.startSync('POST_FRAME');
+      if (!kReleaseMode) {
+        FlutterTimeline.startSync('POST_FRAME');
+      }
       try {
         for (final FrameCallback callback in localPostFrameCallbacks) {
           _invokeFrameCallback(callback, _currentFrameTimeStamp!);
         }
       } finally {
-        Timeline.finishSync();
+        if (!kReleaseMode) {
+          FlutterTimeline.finishSync();
+        }
       }
     } finally {
       _schedulerPhase = SchedulerPhase.idle;