Skip to content

Commit

Permalink
Removed unnecessary backing fields from ScaleBias
Browse files Browse the repository at this point in the history
  • Loading branch information
Ricardo J. Mendez committed Jul 24, 2014
1 parent f77e67a commit 256d4b2
Showing 1 changed file with 78 additions and 92 deletions.
170 changes: 78 additions & 92 deletions Operator/ScaleBias.cs
Original file line number Diff line number Diff line change
@@ -1,93 +1,79 @@
using System.Diagnostics;

namespace LibNoise.Operator
{
/// <summary>
/// Provides a noise module that applies a scaling factor and a bias to the output
/// value from a source module. [OPERATOR]
/// </summary>
public class ScaleBias : ModuleBase
{
#region Fields

private double _scale = 1.0;
private double _bias;

#endregion

#region Constructors

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
public ScaleBias()
: base(1)
{
}

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
/// <param name="input">The input module.</param>
public ScaleBias(ModuleBase input)
: base(1)
{
Modules[0] = input;
}

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
/// <param name="scale">The scaling factor to apply to the output value from the source module.</param>
/// <param name="bias">The bias to apply to the scaled output value from the source module.</param>
/// <param name="input">The input module.</param>
public ScaleBias(double scale, double bias, ModuleBase input)
: base(1)
{
Modules[0] = input;
Bias = bias;
Scale = scale;
}

#endregion

#region Properties

/// <summary>
/// Gets or sets the bias to apply to the scaled output value from the source module.
/// </summary>
public double Bias
{
get { return _bias; }
set { _bias = value; }
}

/// <summary>
/// Gets or sets the scaling factor to apply to the output value from the source module.
/// </summary>
public double Scale
{
get { return _scale; }
set { _scale = value; }
}

#endregion

#region ModuleBase Members

/// <summary>
/// Returns the output value for the given input coordinates.
/// </summary>
/// <param name="x">The input coordinate on the x-axis.</param>
/// <param name="y">The input coordinate on the y-axis.</param>
/// <param name="z">The input coordinate on the z-axis.</param>
/// <returns>The resulting output value.</returns>
public override double GetValue(double x, double y, double z)
{
Debug.Assert(Modules[0] != null);
return Modules[0].GetValue(x, y, z) * _scale + _bias;
}

#endregion
}
using System.Diagnostics;

namespace LibNoise.Operator
{
/// <summary>
/// Provides a noise module that applies a scaling factor and a bias to the output
/// value from a source module. [OPERATOR]
/// </summary>
public class ScaleBias : ModuleBase
{
#region Constructors

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
public ScaleBias()
: base(1)
{
Scale = 1;
}

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
/// <param name="input">The input module.</param>
public ScaleBias(ModuleBase input)
: base(1)
{
Modules[0] = input;
Scale = 1;
}

/// <summary>
/// Initializes a new instance of ScaleBias.
/// </summary>
/// <param name="scale">The scaling factor to apply to the output value from the source module.</param>
/// <param name="bias">The bias to apply to the scaled output value from the source module.</param>
/// <param name="input">The input module.</param>
public ScaleBias(double scale, double bias, ModuleBase input)
: base(1)
{
Modules[0] = input;
Bias = bias;
Scale = scale;
}

#endregion

#region Properties

/// <summary>
/// Gets or sets the bias to apply to the scaled output value from the source module.
/// </summary>
public double Bias { get; set; }

/// <summary>
/// Gets or sets the scaling factor to apply to the output value from the source module.
/// </summary>
public double Scale { get; set; }
#endregion

#region ModuleBase Members

/// <summary>
/// Returns the output value for the given input coordinates.
/// </summary>
/// <param name="x">The input coordinate on the x-axis.</param>
/// <param name="y">The input coordinate on the y-axis.</param>
/// <param name="z">The input coordinate on the z-axis.</param>
/// <returns>The resulting output value.</returns>
public override double GetValue(double x, double y, double z)
{
Debug.Assert(Modules[0] != null);
return Modules[0].GetValue(x, y, z) * Scale + Bias;
}

#endregion
}
}

0 comments on commit 256d4b2

Please sign in to comment.