Add isWorker flag to actor startup #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result, _, err := transaction.Get(ctx, []byte("shutdown")) | ||
| return result, err | ||
| } | ||
| return []byte(strconv.FormatBool(ta.shutdownWasCalled)), nil | ||
| case "getInstantiatePayload": | ||
| return ta.instantiatePayload, nil | ||
| return []byte(ta.instantiatePayload.Payload), nil |
| @@ -27,6 +27,17 @@ type CreateIfNotExist struct { | |||
| InstantiatePayload []byte | |||
| } | |||
|
|
|||
| // InstantiatePayload provides the arguments for initialiazing actors on the STARTUP call. | |||
| type InstantiatePayload struct { | |||
| // IsWorker is a flag that is used to indicate whether the payload is intended for a worker or not | |||
examples/file_cache/file_cache.go
Outdated
| return nil, fmt.Errorf("error unmarshaling InstantiatePayload: %w", err) | ||
| } | ||
| fcp := &FileCacheInstantiatePayload{} | ||
| if err := json.Unmarshal([]byte(p.Payload), fcp); err != nil { |
testdata/tinygo/util/main.go
Outdated
| ) | ||
|
|
||
| // getInstantiatePayload returns the payload provided to the Startup invocation. | ||
| func getInstantiatePayload(payload []byte) ([]byte, error) { | ||
| return instantiatePayload, nil | ||
| return []byte(instantiatePayload.Payload), nil |
| @@ -530,7 +531,13 @@ func (r *environment) InvokeActorDirectStream( | |||
| heartbeatResult.ServerVersion, serverVersion) | |||
| } | |||
|
|
|||
| return r.activations.invoke(ctx, reference, operation, create.InstantiatePayload, payload, false) | |||
| // Wrap instantiation payload into a struct that provides metadata to the actor | |||
| b, err := json.Marshal(types.InstantiatePayload{Payload: create.InstantiatePayload, IsWorker: false}) | |||
There was a problem hiding this comment.
I think we should push these down into activations.go that way we can avoid the allocations/marshalling work except for the case where a new actor is actually being created which will make it ~free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to actor instantiations on the startup call so that apart from the payload user specifies, also an
IsWorkerflag is passed. This allows actors to know if they are being run as workers or not and consequently decide if they can use the transaction or not.