Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields that make usage fail #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing fields that make usage fail #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/DotnetRelease/PatchReleaseOverviewRecords.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ public record RuntimeComponent(
JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure if the type for those with JsonIgnore are correct. I would assume that these should be string? instead.

string VSVersion,

[property: Description("The version of Visual Studio on MacOS that includes this component version."),
JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
string VSMacVersion,

[property: Description("The files that are available for this component.")]
IList<ComponentFile> Files,

Expand All @@ -100,9 +104,15 @@ public record SdkComponent(
[property: Description("The version of Visual Studio that includes this component version.")]
string VSVersion,

[property: Description("The version of Visual Studio on MacOS that includes this component version.")]
string VSMacVersion,

[property: Description("The minimum version of Visual Studio that supports this component version.")]
string VSSupport,

[property: Description("The minimum version of Visual Studio on MacOS that supports this component version.")]
string VSMacSupport,

[property: Description("The version of C# included in the component."),
JsonPropertyName("csharp-version")]
string CSharpVersion,
Expand Down