fix: Handle Emperor's Birthday in 2019 special case #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryu0114h
force-pushed
the
bugfix/emperor-birthday-2019
branch
from
f936f1a to
5571ade
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle Emperor's Birthday Correctly in 2019
This pull request addresses the issue with the handling of the Emperor's Birthday holiday in 2019. As outlined in the Japanese National Holiday, the Emperor's Birthday was not officially observed as a national holiday in 2019 due to the imperial transition.
The changes in this PR ensure that the
TheEmperorsBirthdayholiday is correctly handled for the year 2019, where no holiday is observed. For years prior to 2019, the holiday is set to December 23rd, and from 2020 onwards, it is set to February 23rd as per the current law.This PR helps maintain accurate and up-to-date holiday information in the calendar library, and ensures that the 2019 special case is properly accounted for.