Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made repository REUSE-compatible #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silverhook
Copy link

see https://reuse.software for details

Connected with fish-shell/fish-shell#9326

Copy link
Collaborator

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the headers are probably fine - I don't love having them in e.g. test.cpp, but it's not a big deal.

Having them in the template files is definitely a good idea so the output gets it as well. Typical use for widecharwidth is to generate the files once and then commit them in your repo.

The generated files need to be regenerated instead of manually edited, however.

// SPDX-FileCopyrightText: © 2018 ridiculousfish and widecharwidth contributors
//
// SPDX-License-Identifier: CC0-1.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files (widechar_width.{h,js,py,rs}) are generated from the corresponding files in templates/. They include the hash for the template that they were generated from, so instead of adding the header here you need to add it to the template and then run generate.py again.

@faho faho added the enhancement New feature or request label Dec 22, 2022
@faho
Copy link
Collaborator

faho commented Dec 22, 2022

We should also ask the contributors here to change the formal license from a nebulous "public domain" to CC0-1.0, I'll do that once @ridiculousfish agrees.

The README should probably be adjusted to call it CC0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants