-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator tools #140
Operator tools #140
Conversation
@kylegulshen i cant figure the failure out. the t2 notebook runs fine locally. |
ok now they work ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should investigate the pad issue further but otherwise LGTM. I'm going to push some minor revisions to the random_operators notebook. If we decide to move permute_tensor_factor somewhere else we need to take it out of the notebook too.
return Z | ||
|
||
|
||
def permute_tensor_factors(dims: Union[int, List[int]], perm: List[int]) -> np.ndarray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this to somewhere else? It doesn't really fit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lets make a PR to put this somewhere else.
ax.set_xticks(range(dim_squared)) | ||
ax.set_xlabel("Input Pauli Operator", fontsize=fontsizes) | ||
ax.set_yticks(range(dim_squared)) | ||
ax.set_ylabel("Output Pauli Operator", fontsize=fontsizes) | ||
ax.set_title(title, fontsize= int(np.floor(1.2*fontsizes))) | ||
ax.set_title(title, fontsize= int(np.floor(1.2*fontsizes)), pad=15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pad causes an AttributeError: Unkown property pad
for me when running random_operators.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a matplotlib version problem. Perhaps we should upgrade the requirements.
partial close of #98 |
This is a first pass. Note these things
Not sure that I am happy with the current names or organization. I liked having a big monolithic superoperators module. The imports via
__init__
is awkward, try it in a notebook.Feel free to change and make commits on this branch as you see fit.