Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dist meas nb update #153

Merged
merged 20 commits into from
Jun 19, 2019
Merged

Dist meas nb update #153

merged 20 commits into from
Jun 19, 2019

Conversation

joshcombes
Copy link
Contributor

Still need to write tests for the new file

@joshcombes joshcombes requested a review from a team as a code owner June 17, 2019 08:27
kylegulshen
kylegulshen suggested changes Jun 17, 2019
View reviewed changes
forest/benchmarking/distance_measures.py Outdated Show resolved Hide resolved
forest/benchmarking/distance_measures.py Outdated Show resolved Hide resolved
forest/benchmarking/distance_measures.py Outdated Show resolved Hide resolved
forest/benchmarking/operator_tools/calculational.py Outdated Show resolved Hide resolved
forest/benchmarking/operator_tools/calculational.py Outdated Show resolved Hide resolved
examples/distance_measures.ipynb Outdated Show resolved Hide resolved
examples/distance_measures.ipynb Outdated Show resolved Hide resolved
examples/distance_measures.ipynb Outdated Show resolved Hide resolved
examples/distance_measures.ipynb Outdated Show resolved Hide resolved
forest/benchmarking/distance_measures.py Outdated Show resolved Hide resolved
joshcombes and others added 12 commits June 18, 2019 07:57
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
dea788c 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
777f088 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
336e707 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
62a768b 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update forest/benchmarking/distance_measures.py
e5eaffc 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update forest/benchmarking/distance_measures.py
1fcf625 
Co-Authored-By: Kyle Gulshen <[email protected]>
kyle's point
bc03819
Merge branch 'dist-meas-nb' of github.com:rigetti/forest-benchmarking…
c90200a 
… into dist-meas-nb
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
2ab16f4 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
2f933af 
Co-Authored-By: Kyle Gulshen <[email protected]>
@joshcombes @kylegulshen
Update examples/distance_measures.ipynb
6b3f9ef 
Co-Authored-By: Kyle Gulshen <[email protected]>
address more suggestions
3c75f3c
@joshcombes
Copy link
Contributor Author

will partially close #98

@joshcombes joshcombes mentioned this pull request Jun 18, 2019
Open
12 tasks
@joshcombes
Copy link
Contributor Author

Crap I forgot to put this in a commit message. Some of the text in the distance measures notebook is an edited version of the text grove tomography docs.

kylegulshen
kylegulshen approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@kylegulshen kylegulshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I caught something that should have been a flake8 violation, though I'm not sure.

@joshcombes joshcombes merged commit c5307c2 into master Jun 19, 2019
@joshcombes joshcombes deleted the dist-meas-nb branch June 19, 2019 03:19
@joshcombes joshcombes mentioned this pull request Jun 19, 2019
Closed
@joshcombes
Copy link
Contributor Author

partial close of #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegulshen kylegulshen kylegulshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcombes @kylegulshen