fix!: tokenize keywords and identifiers correctly #428
+157
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now fail on `muta`
This prevents `BITS` from being treated as the keyword `BIT` followed by the identifier `S`.
We could have resolved this the other way, by marking these keywords as reserved, but the Quil spec doesn't allow for `NaN` or `Infinity` and I think this is more useful for our purposes.
Note: These failures don't necessarily block the PR but both authors and reviewers should check the results for unintentional breaking changes. |
jselig-rigetti
approved these changes
Jan 9, 2025
antalsz
force-pushed
the
427-keyword-tokenization
branch
from
7117504 to
3b9cbd0
Compare
|
Note: These failures don't necessarily block the PR but both authors and reviewers should check the results for unintentional breaking changes. |
1 similar comment
Note: These failures don't necessarily block the PR but both authors and reviewers should check the results for unintentional breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tokenization of identifiers and keywords so that keywords are not parsed within word boundaries. Previously,
BITSwould be parsed as the data typeBITfollowed by the identifierS; now, it is correctly parsed as the single identifierBITS.This also fixes the tokenization of
NaN,Inf, andInfinity; previously, these were case-insensitively parsed as floats (with the same incorrect prefix behavior, sonanawould parse as the floatNaNfollowed by the identifiera), but now they are correctly parsed as normal identifiers.Closes #427