Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional device support #68

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Additional device support #68

merged 2 commits into from
Jun 4, 2018

Conversation

caryp
Copy link
Contributor

@caryp caryp commented May 31, 2018

This does not directly fix #65 , but it does allow you to specify devices to include in LVM via attributes. For example:

node.override['ephemeral_lvm']['additonal_devices'] = [ "/dev/nvme0n1" ]
include_recipe 'ephemeral_lvm'

@rshade
Copy link
Contributor

rshade commented May 31, 2018

@caryp you cool with me pulling this into a separate branch and fixing up the tests?

@caryp
Copy link
Contributor Author

caryp commented May 31, 2018

Absolutely! Thanks, @rshade !! Hope you are well :)

@rshade rshade changed the base branch from master to additional_device_support June 4, 2018 16:01
@rshade rshade merged commit 17f151f into rightscale-cookbooks:additional_device_support Jun 4, 2018
@rshade
Copy link
Contributor

rshade commented Jun 4, 2018

I am indeed, Hope you are well also.

rshade added a commit that referenced this pull request Jul 13, 2018
@rshade
Additional device support (#68) (#71)
b90a2ad 
* Additional device support (#68)

* new additonal_devices attribute

* back down lvm version

* Running Cookstyle

* trying to update chefdk

* updating foodcritic rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshade rshade rshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caryp @rshade