sort by createdOn client side

rilldata · Sep 18, 2024 · 6225b5a · 6225b5a
1 parent c5b6340
commit 6225b5a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 17 deletions.
diff --git a/web-admin/src/features/public-urls/PublicURLsTable.svelte b/web-admin/src/features/public-urls/PublicURLsTable.svelte
@@ -30,13 +30,7 @@
   export let onDelete: (deletedTokenId: string) => void;
 
   let virtualListEl: HTMLDivElement;
-  let sorting: SortingState = [
-    // Data gets arbitrary sorted as user scrolls for more data
-    // {
-    //   id: "createdOn",
-    //   desc: true,
-    // },
-  ];
+  let sorting: SortingState = [];
 
   function formatDate(value: string) {
     return new Date(value).toLocaleDateString(undefined, {
@@ -96,15 +90,6 @@
         return date;
       },
     },
-    {
-      accessorKey: "createdOn",
-      header: "Created on",
-      cell: (info) => {
-        if (!info.getValue()) return "-";
-        const date = formatDate(info.getValue() as string);
-        return date;
-      },
-    },
     {
       accessorKey: "actions",
       header: "",

diff --git a/web-admin/src/routes/[organization]/[project]/-/settings/public-urls/+page.svelte b/web-admin/src/routes/[organization]/[project]/-/settings/public-urls/+page.svelte
@@ -48,6 +48,11 @@
     };
   });
 
+  // REVISIT when server-side sorting is implemented
+  $: sortedAllRowsWithDashboardTitle = allRowsWithDashboardTitle.sort(
+    (a, b) => new Date(b.createdOn).getTime() - new Date(a.createdOn).getTime(),
+  );
+
   const queryClient = useQueryClient();
   const revokeMagicAuthToken = createAdminServiceRevokeMagicAuthToken();
 
@@ -86,7 +91,7 @@
         <NoPublicURLCTA />
       {:else}
         <PublicURLsTable
-          data={allRowsWithDashboardTitle}
+          data={sortedAllRowsWithDashboardTitle}
           query={$magicAuthTokensInfiniteQuery}
           onDelete={handleDelete}
         />