Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to leaderboard test to account for inconsistent Playwright behavior #3688

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 12, 2023

This PR fixes an issue that occurs when running tests locally (and sometimes in CI).

Re: leaderboard-and-dim-table-sort.spec.ts

  1. Adds a page timeout after selecting the Percentage change sorting option to allow for the Leaderboard rankings to update
  2. Broadens the subsequent selectors by using RegEx rather than a specific string. The reason for this is that some Playwright runs trigger the hover effect on the element, which means that the "name" selector may sometimes include an additional number (see below)
Screenshot 2023-12-12 at 6 35 39 PM

If similar issues arise in the future, I think the other selectors could be broadened without issue. Also, if these are too broad, for whatever reason, this PR could be updated with a slightly more complex RegEx to capture both hover and not hovered states.

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, test passes for me locally now 👍

@briangregoryholmes briangregoryholmes merged commit 410e83e into main Dec 12, 2023
2 checks passed
@briangregoryholmes briangregoryholmes deleted the fix-leaderboard-test branch December 12, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants