removed WithTween wrapper around clipPath to prevent fickering when charts are updated #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harts are updated
djbarnwal
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3524
Lines that do not extend to the right edge of the graph are clipped using a clipPath. Wrapping clipPath in WithTween delays the appearance of the clipping by a fraction of a second, causing unintended flickering when sorting or updating data.
This PR removes the wrapping of the clipPath element with no immediately apparent change in functionality. However, there may be a good reason that I am not yet aware of for why the tweening is necessary on the clipPath.