Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: measure menu #5741

Merged
merged 3 commits into from
Sep 20, 2024
Merged

refactor: measure menu #5741

merged 3 commits into from
Sep 20, 2024

Conversation

briangregoryholmes
Copy link
Contributor

This is a stopgap cleanup in preparation for #5732.

@briangregoryholmes briangregoryholmes marked this pull request as draft September 19, 2024 20:58
@briangregoryholmes briangregoryholmes self-assigned this Sep 19, 2024
@briangregoryholmes briangregoryholmes marked this pull request as ready for review September 19, 2024 21:05
ericpgreen2
ericpgreen2 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UXQA: I'm not seeing any hover state when I mouse over the options in the leaderboard measure dropdown menu. I'd expect a hover state that matches the one in the dimension visibility dropdown menu to its left.

Approving so you can merge when ready.

@briangregoryholmes
Copy link
Contributor Author

Strange. Setting the role to menuitem breaks the hover state. Left it as is and changed the selectors in the tests.

@briangregoryholmes briangregoryholmes merged commit 326deb3 into main Sep 20, 2024
7 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/measure-menu-cleanup branch September 20, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@briangregoryholmes briangregoryholmes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briangregoryholmes @ericpgreen2