model executor for postgres and mysql to duckdb #6083
+301
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
changed the title
k-anshul
force-pushed
the
me_postgres_duckdb
branch
from
f1e6c60 to
fb1b3e1
Compare
begelundmuller
requested changes
Dec 19, 2024
| @@ -123,3 +132,55 @@ func allMySQLDataTypesTest(t *testing.T, db *sql.DB, dsn string) { | |||
| require.NoError(t, res.Close()) | |||
| require.NoError(t, to.Close()) | |||
| } | |||
|
|
|||
| func mysqlToDuckDB(t *testing.T, dsn string) { | |||
There was a problem hiding this comment.
Can we move this test to a test file that starts with model_executor_ instead? For when we drop the transporter files?
There was a problem hiding this comment.
Actually I planned to rename this file and drop the transporter test when re drop the transporter files. Till then kept it in the same file to avoid creating more test containers and keep test time short.
I am okay to also create new test if you prefer that way.
| @@ -86,3 +93,80 @@ func allDataTypesTest(t *testing.T, db *sql.DB, dbURL string) { | |||
| require.NoError(t, res.Close()) | |||
| require.NoError(t, to.Close()) | |||
| } | |||
|
|
|||
| func pgxToDuckDB(t *testing.T, pgdb *sql.DB, dbURL string) { | |||
There was a problem hiding this comment.
Similar comment about moving to a model executor related test file
k-anshul
commented
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask for https://github.com/rilldata/rill-private-issues/issues/854
Sample model yaml that ingests from postgres.