Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ advanced measures window #6152

Merged
merged 9 commits into from
Jan 16, 2025
Merged

docs/ advanced measures window #6152

merged 9 commits into from
Jan 16, 2025

Conversation

royendo
Copy link
Contributor

@royendo royendo commented Nov 25, 2024

No description provided.

@royendo
Copy link
Contributor Author

royendo commented Nov 25, 2024

@rohithreddykota added the window example here :)

the per: example is not yet implemented, so this should be okay for now

@royendo royendo marked this pull request as ready for review November 27, 2024 18:23
@royendo royendo requested a review from mindspank November 27, 2024 18:23
@royendo royendo added the Type:Documentation Improvements or additions to documentation label Dec 4, 2024
@@ -60,7 +61,22 @@ In your Rill project directory, create a metrics view, `<metrics_view>.yaml`, fi
- `currency_eur` — output rounded to 2 decimal points prepended with a euro symbol: `€`
- `percentage` — output transformed from a rate to a percentage appended with a percentage sign
- `interval_ms` — time intervals given in milliseconds are transformed into human readable time units like hours (h), days (d), years (y), etc.

- **`window`** — can be used for [advanced window expressions](/build/metrics-view/expressions), cannot be used with simple measures _(optional)_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A limitation with window expressions -

we only support window functions post-aggregation by the dims, not pre the aggregation

Not sure if you would like to add it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a note

Copy link
Contributor

@rohithreddykota rohithreddykota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and added couple suggestions

@royendo royendo merged commit 40fae05 into main Jan 16, 2025
5 checks passed
@royendo royendo deleted the docs/advanced-measures branch January 16, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants