e2e github actions #6303
e2e github actions #6303
Conversation
| run: | | ||
| echo "matrix=$(jq -n '[ | ||
| "web-admin" | select(env.FILTER_ADMIN == "true" or env.FILTER_COMMON == "true"), | ||
| "web-local" | select(env.FILTER_LOCAL == "true" or env.FILTER_COMMON == "true") | ||
| ]' | jq -c)" >> "$GITHUB_OUTPUT" | ||
| env: | ||
| FILTER_ADMIN: ${{ steps.filter.outputs.admin }} | ||
| FILTER_COMMON: ${{ steps.filter.outputs.common }} | ||
| FILTER_LOCAL: ${{ steps.filter.outputs.local }} |
There was a problem hiding this comment.
It feels like these environment variables are adding an extra layer of indirection. Could we use filter.outputs directly in the jq command like: select(${{ steps.filter.outputs.admin }} == "true" or ${{ steps.filter.outputs.common }} == "true")?
There was a problem hiding this comment.
Further, can we treat the filter output like a typical boolean, not a string, like:
select(${{ steps.filter.outputs.admin }} or ${{ steps.filter.outputs.common }})
or even without the select function:
if ${{ steps.filter.outputs.admin }} or ${{ steps.filter.outputs.common }} then "web-admin" else empty end
There was a problem hiding this comment.
yeah, it doesn't have access to steps.filter.outputs.
There was a problem hiding this comment.
Are you sure? This example seems to show it's possible.
No description provided.