Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect loop when home bookmark has missing compare dimension #6317

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix: redirect loop when home bookmark has missing compare dimension #6317

merged 1 commit into from
Jan 1, 2025
+13 −8

Conversation

AdityaHegde
Copy link
Collaborator

No description provided.

@AdityaHegde AdityaHegde added the Type:Bug Something isn't working label Dec 23, 2024
ericpgreen2
ericpgreen2 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, though this makes the component even more complex. I'd encourage you to ask AI for suggestions on how to simplify all this code.

@AdityaHegde
Copy link
Collaborator Author

Sounds good. Lets do a simplification follow up

@AdityaHegde AdityaHegde merged commit 9fdb50b into main Jan 1, 2025
9 checks passed
@AdityaHegde AdityaHegde deleted the fix/redirect-loop branch January 1, 2025 05:44
AdityaHegde added a commit that referenced this pull request Jan 1, 2025
@AdityaHegde
Fix redirect loop in certain cases (#6317)
0d54c2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees
No one assigned
Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @ericpgreen2