fix: bookmark interaction with url params #6318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdityaHegde
commented
Dec 20, 2024
AdityaHegde
commented
- Disable delete while bookmark is being deleted. This to avoid multiple calls to delete per click.
- Editing a bookmark with filters only doesnt set the toggle to true.
- Entering a dashboard with no timeseries and a home bookmark doesnt load the dashboard
djbarnwal
approved these changes
Dec 24, 2024
AdityaHegde
added a commit
that referenced
this pull request
Dec 30, 2024
* Disable delete bookmark button while deleting * Fix filterOnly calucation for bookmark edit * Fix dashboards without timestamp and home bookmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.