Skip to content

Commit

Permalink
Don't suggest a runtime dependency for TOOL_DEPENDS
Browse files Browse the repository at this point in the history
  • Loading branch information
rillig committed Apr 26, 2024
1 parent 1b18c1f commit 06c4df8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion v23/package_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ func (s *Suite) Test_Package__TOOL_DEPENDS(c *check.C) {

t.CheckOutputLines(
"WARN: Makefile:20: " +
"Use USE_TOOLS+=perl:run instead of this dependency.")
"Use USE_TOOLS+=perl instead of this dependency.")
}

func (s *Suite) Test_NewPackage(c *check.C) {
Expand Down
6 changes: 5 additions & 1 deletion v23/vartypecheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,11 @@ func (cv *VartypeCheck) DependencyWithPath() {
case "gettext":
cv.Warnf("Use USE_TOOLS+=msgfmt instead of this dependency.")
case "perl5":
cv.Warnf("Use USE_TOOLS+=perl:run instead of this dependency.")
if cv.Varname == "TOOL_DEPENDS" {
cv.Warnf("Use USE_TOOLS+=perl instead of this dependency.")
} else {
cv.Warnf("Use USE_TOOLS+=perl:run instead of this dependency.")
}
case "gmake":
cv.Warnf("Use USE_TOOLS+=gmake instead of this dependency.")
}
Expand Down

0 comments on commit 06c4df8

Please sign in to comment.