opencc中文路径问题 #654
Closed
opencc中文路径问题 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复Windows下opencc中文路径问题
在64位项目中引用时，需要使会话ID统一大小，由于底层传上来的是指针，32位程序要使用UINT64来保存它，这里要将类型统一，否则模板就匹配不上。
修复opencc对中文路径的支持
修复Win平台用户目录中缺少「default.custom.yaml」、「weasel.custom.yaml」两个文件时，设定窗口无法打开
|
Windows平台下首次安装时，用户目录里没有「default.custom.yaml」、「weasel.custom.yaml」两个文件，设定窗口无法打开。目前测试，Windows平台可正常运行修改过的代码。 |
src/rime/gear/simplifier.cc
Outdated
| @@ -36,7 +40,21 @@ class Opencc { | |||
| LOG(INFO) << "initializing opencc: " << config_path; | |||
| opencc::Config config; | |||
| try { | |||
| #ifdef WIN32 | |||
There was a problem hiding this comment.
建议把这段提炼成单个方法，方便其他地方引用
There was a problem hiding this comment.
或者也可以使用 OpenCC 的方法来实现，这样就不用自己费劲写了：
There was a problem hiding this comment.
似乎只有Windows平台使用多字节字符串路径，这个转换只有opencc会用到，别的地方用不到了。其它平台在这里传入的是utf8，Windows平台传入的却是多字节，而opencc要求必须传入utf8字符串。
Windows下的opencc中文路径识别
zhaozg
reviewed
Jun 27, 2023
src/rime/lever/custom_settings.cc
Outdated
| @@ -43,7 +43,7 @@ bool CustomSettings::Load() { | |||
| fs::path custom_config_path = | |||
| fs::path(deployer_->user_data_dir) / custom_config_file(config_id_); | |||
| if (!custom_config_.LoadFromFile(custom_config_path.string())) { | |||
| return false; | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
之前是改过的。但梁大说这两个文件在Weasel端创建，librime是几个平台共用的库，不应该创建平台相关的文件。所以就删除了。
There was a problem hiding this comment.
在网页上改的，有时候空格没注意到。文件当时是本机编译的，环境变量不太一样，用github同步时会冲突，只网页上修改了相关的代码片断。
|
Closing in favor of #689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复Windows下用户词库所在路径包含中文的问题。