fix #652: process whole conversion chain #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* continue to process whole conversion chain for whole candidate matching except for the candidate original form
amorphobia
commented
Jun 2, 2023
src/rime/gear/simplifier.cc
Outdated
Comment on lines
253
to
259
| string simplified; | ||
| const bool success_converted = opencc_->ConvertText(original->text(), &simplified); | ||
| if (success_converted && original->text().compare(simplified) != 0) { | ||
| PushBack(original, result, simplified); | ||
| } else { | ||
| PushBack(original, result, forms[i]); | ||
| } |
There was a problem hiding this comment.
I have not tested your suggestion yet. I have a question. Would it lose results if a character can be converted into multiple ones?
For example, 「才」 would be converted to 「才」 and 「纔」, but it will use ConvertText first, get result 「才」 (or 「纔」, not test yet), and go to success branch. Then the result 「纔」 will lose.
eagleoflqj
approved these changes
Aug 9, 2023
|
不应重复转换 |
|
@lotem is right. Should fix it in ConvertWord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes #652
Unit test
Manual test
Code Review
Additional Info