Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow only logging to stderr with minloglevel #730

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #727

Feature

Before:
If app_name not provided, only log to stderr, min_log_level doesn't work at all.
If app_name provided, log to both stderr and file (if log_dir not provided, use temporary dir).

After:
If app_name provided and provide log_dir as empty string, log only to stderr with min_log_level working.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj merged commit 6d1b9b6 into rime:master Oct 8, 2023
8 checks passed
@eagleoflqj eagleoflqj deleted the log-stderr branch October 8, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to control log level while only log to stderr
1 participant