allow only logging to stderr with minloglevel #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #727
Feature
Before:
If
app_name
not provided, only log to stderr,min_log_level
doesn't work at all.If
app_name
provided, log to both stderr and file (iflog_dir
not provided, use temporary dir).After:
If
app_name
provided and providelog_dir
as empty string, log only to stderr withmin_log_level
working.Unit test
Manual test
Code Review
Additional Info