Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge build.bat and build-clang.bat #737

Closed
wants to merge 3 commits into from
Closed

Merge build.bat and build-clang.bat #737

wants to merge 3 commits into from

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

Merge build.bat and build-clang.bat

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 6 times, most recently from 46d5b86 to 8a29f8d Compare October 15, 2023 08:32
lotem
lotem requested changes Oct 15, 2023
View reviewed changes
build.bat Outdated Show resolved Hide resolved
@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 5 times, most recently from 3146e6e to f8dce39 Compare October 18, 2023 04:37
@WhiredPlanck WhiredPlanck reopened this Oct 18, 2023
@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 15 times, most recently from a1fa482 to 55e866d Compare October 21, 2023 07:42
@WhiredPlanck WhiredPlanck reopened this Oct 22, 2023
@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 5 times, most recently from 754e6e0 to 81552c8 Compare October 22, 2023 08:29
@WhiredPlanck WhiredPlanck requested a review from lotem October 22, 2023 09:00
@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 3 times, most recently from 5e3ab7a to 1a8d6f0 Compare October 24, 2023 11:09
@WhiredPlanck WhiredPlanck force-pushed the merge-build branch 4 times, most recently from e2fe305 to 3f66be5 Compare October 26, 2023 12:38
@WhiredPlanck WhiredPlanck deleted the merge-build branch October 29, 2023 09:57
@WhiredPlanck WhiredPlanck restored the merge-build branch November 11, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj left review comments

@lotem lotem Awaiting requested review from lotem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhiredPlanck @lotem @eagleoflqj