feat(api): new api to save input history without cleaning up sessions #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
requested changes
Feb 1, 2024
| @@ -465,6 +466,7 @@ typedef struct rime_api_t { | |||
| Bool (*deploy_config_file)(const char* file_name, const char* version_key); | |||
|
|
|||
| Bool (*sync_user_data)(void); | |||
| Bool (*sync_user_dict)(void); | |||
| @@ -167,6 +167,11 @@ RIME_API Bool RimeSyncUserData() { | |||
| return Bool(deployer.StartMaintenance()); | |||
| } | |||
|
|
|||
| RIME_API Bool RimeSyncUserDict() { | |||
| Deployer& deployer(Service::instance().deployer()); | |||
| return Bool(deployer.ScheduleTask("user_dict_sync")); | |||
There was a problem hiding this comment.
Is this safe to do while user input session accesses user dictionary simutaniously?
lotem
reviewed
Feb 7, 2024
| @@ -167,6 +167,11 @@ RIME_API Bool RimeSyncUserData() { | |||
| return Bool(deployer.StartMaintenance()); | |||
| } | |||
|
|
|||
| RIME_API Bool RimeSyncUserDict() { | |||
| Deployer& deployer(Service::instance().deployer()); | |||
| return Bool(deployer.ScheduleTask("user_dict_sync")); | |||
There was a problem hiding this comment.
Is it working? It doesn't look like actually running the task.
|
I believe the code is not working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #754
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info