Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add zsh-rime #881

Merged
merged 1 commit into from
Jun 17, 2024
Merged

docs: add zsh-rime #881

merged 1 commit into from
Jun 17, 2024

Conversation

Freed-Wu
Copy link
Contributor

Update README.md

@LEOYoon-Tsaw
Copy link
Member

Looks suspicious to me, 0 star 0 fork, recently ported from another author

@lotem
Copy link
Member

lotem commented May 23, 2024

interesting.

@Freed-Wu
Copy link
Contributor Author

Looks suspicious to me

You can take a look at the demo video https://asciinema.org/a/660633

interesting.

I just want to try if we can input CJKV characters in command line without GUI IME.
We use the similar principle of shell's <TAB> completion. That is, input pinyin in zsh then press a hotkey, we will get all candidates in completions. Just like you input c<TAB> and get cd, cp, ...

recently ported from another author

The original project is a zsh module. zsh module is written in C, and need some code about the build system autotools and some header files. So I reuse autotools and zsh.h, XXX.h, ... That is why it is forked.

@Freed-Wu
Copy link
Contributor Author

Looks suspicious to me

I also maintain another project to try input CJKV characters in Vim https://github.com/tonyfettes/coc-rime
The demo video is https://asciinema.org/a/660635 Hope it can make you believe me.

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can understand both your enthusiasm and others' suspect.
Your project clearly to serve a different purpose than the project you forked.
I suggest you detach your fork. It preserves the original author's commits and makes your project searchable in GitHub. It also enables contributor list. I believe that will make your project live longer and more meaningful to be listed here.
What do you think?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jun 5, 2024

If I recreate a repo without the fork, Can this PR be accepted?

@lotem
Copy link
Member

lotem commented Jun 5, 2024

I don't see issues with the repo being a fork.
If the code can be shared, forking the repo and use it for a different purpose looks good to me.

@lotem lotem merged commit 7e3d286 into rime:master Jun 17, 2024
10 checks passed
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jul 9, 2024

screen-2024-07-09-22-18-24

I finish it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants