feat(translator): allow a translator to take multiple tags #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksqsf
changed the title
ksqsf
commented
Aug 14, 2024
| @@ -146,8 +146,10 @@ class TranslatorOptions { | |||
| bool IsUserDictDisabledFor(const string& input) const; | |||
|
|
|||
| const string& delimiters() const { return delimiters_; } | |||
| const string& tag() const { return tag_; } | |||
| void set_tag(const string& tag) { tag_ = tag; } | |||
| vector<string> tags() const { return tags_; } | |||
There was a problem hiding this comment.
This is not const vector<string>& due to a compilation eror in librime-lua which I don't know how to solve.
lotem
approved these changes
Sep 1, 2024
src/rime/gear/translator_commons.cc
Outdated
| @@ -132,6 +131,20 @@ TranslatorOptions::TranslatorOptions(const Ticket& ticket) { | |||
| config->GetList(ticket.name_space + "/comment_format")); | |||
| user_dict_disabling_patterns_.Load( | |||
| config->GetList(ticket.name_space + "/disable_user_dict_for_patterns")); | |||
| string tag; | |||
| if (config->GetString(ticket.name_space + "/tag", &tag)) { | |||
| // replace the first tag, and undersand /tags as extra tags | |||
There was a problem hiding this comment.
yes, fixed.
also fixed a case where the invariant could be broken.
ksqsf
force-pushed
the
translator-tags
branch
from
2719e27
to
ef02973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Feature
Allow script_translator and table_translator to take multiple tags.
To keep compatibility:
tag: tags is set to that tagtags: tags is set to that listtagandtags: tag is the first element in the list, andtagsis understood similar toextra_tagsUnit test
Manual test
Code Review
Additional Info