Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): export librime 0.9 API as extern C #965

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(api): export librime 0.9 API as extern C #965

merged 2 commits into from
Dec 20, 2024

Conversation

lotem
Copy link
Member

@lotem lotem commented Dec 20, 2024

Fixes #964

RIME_API should include extern "C";
C++ symbols are now DLL-exported by the RIME_DLL macro instead.

lotem added 2 commits December 20, 2024 13:11
@lotem
chore(levers_api): follow up rime#892
f8d9124
@lotem
fix(api): export librime 0.9 API as extern C
2930c26 
fixes rime#964

use RIME_DLL for exported C++ symbols.
use RIME_API for RIME API C functions.
@lotem lotem requested review from fxliang and eagleoflqj December 20, 2024 06:36
@lotem lotem merged commit 2930c26 into rime:master Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxliang fxliang Awaiting requested review from fxliang

@eagleoflqj eagleoflqj Awaiting requested review from eagleoflqj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

librime 1.12.0 not work with weasel 0.14.3.0
1 participant
@lotem