-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix undefined portal #334
base: master
Are you sure you want to change the base?
fix undefined portal #334
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 27 27
Lines 1037 1037
Branches 104 104
=======================================
Hits 1013 1013
Misses 9 9
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Automated benchmark results (pass #0): passed
|
@riophae Hi. Can you accept this PR please? |
LETS GO! bug still exists since one year .. is the project dead? |
@riophae Please take a look at this PR 🙏 |
@riophae please accept the PR! |
@riophae Can you please accept the PR - this fix actually makes the project usable also in another setting. |
make sure portal and ref exists before return