Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-4649: Adjust socials for developer-centric targets #166

Merged
merged 7 commits into from
Sep 18, 2024
Merged

DOC-4649: Adjust socials for developer-centric targets #166

merged 7 commits into from
Sep 18, 2024

Conversation

msmygit
Copy link
Collaborator

@msmygit msmygit commented Sep 18, 2024 •
edited
Loading

See the request from Carter Rabasa here in the slack channel.

@kurtenj we need the social icon for Discord named social-discord.svg in the appropriate location like others to complete this PR. Where can we get such icons? TY

cc/ @kurtenj @aimurphy @eric-schneider @colegoldsmith

@msmygit msmygit added documentation Improvements or additions to documentation enhancement New feature or request quick win labels Sep 18, 2024
@msmygit msmygit requested review from kurtenj and aimurphy September 18, 2024 13:22
@msmygit msmygit self-assigned this Sep 18, 2024
@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@aimurphy aimurphy requested a review from crtr0 September 18, 2024 13:57
@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@msmygit
Copy link
Collaborator Author

msmygit commented Sep 18, 2024

https://datastax.jira.com/browse/DOC-4649

@msmygit msmygit changed the title Adjust socials for developer-centric targets DOC-4649: Adjust socials for developer-centric targets Sep 18, 2024
@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@colegoldsmith
Copy link
Collaborator

@msmygit @kurtenj I committed an svg file that is sized properly and has the right fill color, and inverts color in dark mode. I sourced it from here https://discord.com/branding

@msmygit msmygit marked this pull request as ready for review September 18, 2024 15:20
@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@crtr0
Copy link

crtr0 commented Sep 18, 2024

The Github link should not have changed, please point to: https://github.com/datastax

@plpesvc-ds
Copy link

plpesvc-ds commented Sep 18, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Sep 18, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@colegoldsmith colegoldsmith merged commit 1cc662a into main Sep 18, 2024
2 checks passed
@colegoldsmith colegoldsmith deleted the ms-update-footer branch September 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colegoldsmith colegoldsmith colegoldsmith approved these changes

@crtr0 crtr0 crtr0 approved these changes

@kurtenj kurtenj Awaiting requested review from kurtenj

@aimurphy aimurphy Awaiting requested review from aimurphy

@eric-schneider eric-schneider Awaiting requested review from eric-schneider

Assignees

@msmygit msmygit

Labels
documentation Improvements or additions to documentation enhancement New feature or request quick win
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msmygit @mlr @plpesvc-ds @colegoldsmith @crtr0